Fix/blog preview img #1758
Fix/blog preview img #1758
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1758 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 633
Branches 196 196
=========================================
Hits 633 633 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hope you're doing well! Just a quick reminder, it would be great if you could wait to get officially assigned to an issue before opening a PR. This helps us manage contributions more smoothly and avoid overlapping efforts. Thanks a lot for your understanding. |
|
I thought since Benjamin said you can drop PR without assigning the person, but the person stated he isn't working on it. the issue was very small so I thought it didn't need assigning, I will make sure to get it assigned first from next time. |
There was a problem hiding this comment.
Thanks for your solution @animeshsahoo1 , it's a great start! 😊
Just a small observation: there's a slight height inconsistency among the images on the blog page. It would be great if you could make the image heights uniform across the page.
Also, the issue description specifically mentions the home page and not blog page, so if you could take a look at that part as well, it would be really helpful.
Let me know if you need any clarification. Thanks again for your efforts!
github-project-automation
bot
moved this from Ready to review
to Changes requested
in PR - Triage Group
|
@Utkarsh-123github got it I didn't read properly I can add object fill to the home page part in blog page the code has changed I think its nice now but I tried to find a way to keep height same without cutting out something but I don't think its possible since the aspect ratio is different for all images. let me know what you think |
|
Hi @animeshsahoo1 , I checked it out locally. |
|
@Utkarsh-123github oh ok got it |
animeshsahoo1
force-pushed
the
fix/blog-preview-img
branch
from
936748c to
91b1546
Compare
|
@Utkarsh-123github could you take a look at it again and tell me if there something that requires change |
What kind of change does this PR introduce?
A Bugfix
Issue Number:
Closes #1755
Screenshots/videos:
Adding object contain will make other blog images not fit in properly
adding object fill will do the job
Summary
the suggested solution was to use object-contain but that makes other images not fit in properly, instead using object-fill will do the work properly
Does this PR introduce a breaking change?
NO
Checklist
Please ensure the following tasks are completed before submitting this pull request.